Open
Conversation
This commit adds behavior where the fee setter can override the fee for specific pools if needed
snreynolds
reviewed
Dec 9, 2025
| /// @param pool The pool address | ||
| /// @param feeTier The fee tier of the pool (used for default lookup) | ||
| /// @return The fee value to apply (0 if sentinel, override if set, otherwise default) | ||
| function _getEffectiveFee(address pool, uint24 feeTier) internal view returns (uint8) { |
Contributor
There was a problem hiding this comment.
Maybe instead of hitting the defaultFees path last, we can check that first unless you think it will be most common to have an override value
snreynolds
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds behavior where the fee setter can override the fee for specific pools if needed