feat: add L2 deployment addresses and propagate-fees CLI command by marktoda · Pull Request #127 · Uniswap/protocol-fees

marktoda · 2026-02-20T22:04:17Z

✨ Claude-Generated Content

Summary

Adds deployed contract addresses for mainnet V3OpenFeeAdapter and 8 L2 chains to README documentation, with supporting deployment script and a new CLI command for propagating protocol fees.

Changes

Documentation:

Add V3OpenFeeAdapter address (0xf2371551Fe3937Db7c750f4DfABe5c2fFFdcBf5A) to Ethereum Mainnet section
Add deployment addresses for 8 L2 chains with block explorer links:
- World Chain (480): Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- Soneium (1868): CrossChainAccount, Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- Celo (42220): CrossChainAccount, Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- Zora (7777777): Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- X Layer (196): CrossChainAccount, Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- Arbitrum One (42161): Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- OP Mainnet (10): Deployer, TokenJar, Releaser, V3OpenFeeAdapter
- Base (8453): Deployer, TokenJar, Releaser, V3OpenFeeAdapter
  Deployment Scripts:
Add script/DeployV3OpenMainnet.s.sol for V3OpenFeeAdapter deployment
Fix V3OpenMainnetDeployer.sol to set global default fee during deployment
CLI Tooling:
Rename CLI from merkle-generator to protocol-fees
Add propagate-fees command for discovering V3 pools and batch-updating protocol fees via V3OpenFeeAdapter
Add merkle-generator/src/abi.ts with minimal contract ABIs
Add merkle-generator/src/propagate-fees.ts implementing pool discovery, fee checking, and batch execution
Add unit tests for propagate-fees functionality

Notes

Soneium, Celo, and X Layer include CrossChainAccount contracts for L2 governance
The propagate-fees command scans PoolCreated events, checks current vs expected fees, and batch-updates pools with incorrect fees
Markdown formatting fixes applied to README tables

github-actions · 2026-02-20T22:04:54Z

🤖 Claude Code Review

✅ Review still valid — No new code changes detected since the last review.

_{💡 To force a fresh review, add a comment containing @request-claude-review.}

Summary

This PR adds:

A new CLI command propagate-fees to discover V3 pools and batch-update their protocol fees via V3OpenFeeAdapter
A deployment script for mainnet V3OpenFeeAdapter
README updates with deployment addresses for multiple chains
Minor package renaming from merkle-generator to protocol-fees

The implementation is well-structured with good test coverage and clean separation of concerns.

Observations

Security Note

The --private-key flag in the CLI command (merkle-generator/src/cli.ts:400) accepts keys directly on the command line. This is functional but worth noting that command-line arguments can appear in shell history and process listings. For production use, consider supporting environment variables or file-based key loading in the future.

Deployer Script

The DeployV3OpenMainnet.s.sol deployment script looks straightforward. The V3OpenMainnetDeployer constructor now correctly sets both the global defaultFee and the per-tier defaults, ensuring pools have a fallback fee regardless of their tier.

TypeScript Implementation

The propagate-fees.ts implementation is clean:

Pool discovery uses chunked event scanning
Sequential pool checking with proper uninitialized pool handling
Batch transaction execution with wait-for-receipt between batches
Tests cover the core functions adequately

Minor Observations

The default batchSize of 500 pools per transaction is reasonable for gas limits
The checkFees function processes pools sequentially - this could be slow for chains with thousands of pools, but is acceptable for a CLI tool
Test coverage is focused on unit tests with mocks, which is appropriate for this functionality

_{💡 Want a fresh review? Add a comment containing @request-claude-review to trigger a new review at any time.}

github-actions

📋 Review verdict: APPROVE

👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.