refactor(flashtestations-sdk): simplify workload ID computation by re… #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melvillian
requested review from
0x00101010,
aayala-uniswap,
cgkol,
charlesma4,
kailuo-uniswap,
paranoiacblack and
trianglesphere
Melvillian
force-pushed
the
flashtestations-sdk/use-workload-calculation-without-bitmasking
branch
from
ea0d40c to
d4f5eca
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (11/25/25)3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
0x00101010
approved these changes
Nov 25, 2025
…moving bitmasking operations This commit removes the bitwise preprocessing operations (XOR, AND, NOT, OR) from the workload ID computation to align with the updated BlockBuilderPolicy contract implementation. Previously, the workload ID was computed by applying bitmasks to xFAM and tdAttributes values before hashing, but the upstream contract has simplified this logic to directly hash the raw register values. You can find the original change here: flashbots/flashtestations#53
Melvillian
force-pushed
the
flashtestations-sdk/use-workload-calculation-without-bitmasking
branch
from
d4f5eca to
87b1296
Compare
paranoiacblack
approved these changes
Nov 25, 2025
Melvillian
deleted the
flashtestations-sdk/use-workload-calculation-without-bitmasking
branch
ConjunctiveNormalForm
added a commit
that referenced
this pull request
Dec 8, 2025
ConjunctiveNormalForm
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…moving bitmasking operations
Description
This commit removes the bitwise preprocessing operations (XOR, AND, NOT, OR) from the workload ID computation to align with the updated BlockBuilderPolicy contract implementation. Previously, the workload ID was computed by applying bitmasks to xFAM and tdAttributes values before hashing, but the upstream contract has simplified this logic to directly hash the raw register values.
You can find the original change here: flashbots/flashtestations#53
How Has This Been Tested?
manually, using the same tests as are in the flashtestations smart contract repo
Are there any breaking changes?
yes, but nobody uses this so it's ok
(Optional) Feedback Focus
just run
yarn testin the flashtestations-sdk package and make sure they pass.