fix: substract swap fees in totalValueLockedToken0/1 calculation#25
Open
Marco75116 wants to merge 1 commit intoUniswap:mainfrom
Open
fix: substract swap fees in totalValueLockedToken0/1 calculation#25Marco75116 wants to merge 1 commit intoUniswap:mainfrom
Marco75116 wants to merge 1 commit intoUniswap:mainfrom
Conversation
Author
|
@mz- @Aismit @tarikbellamine @mzywang am I wrong ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where swap fees are not being included in the
totalValueLockedToken0andtotalValueLockedToken1calculations.Currently, all fees remain permanently in the pool, leading to inaccurate pool data. These fees are not removed for in either Swap events or ModifyLiquidity events with liquidityDelta equal to 0 (which represent collect).