add tempo support with aggregator hook handling#68
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ciyengar3
force-pushed
the
tempo-testnet
branch
from
ed67229 to
a235c52
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pathUSD is definitionally $1, so we skip the oracle pool lookup and return a static price of 1 for the Tempo testnet. All other networks fall through to the existing getNativePriceInUSD path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
getAggregatorHookAddress → getUSDStableStableAggregatorHookAddress isAggregatorPool → isUSDStableStableAggregatorPool Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…okAddress Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… for TVL Update ABI to reflect two-value return type and compute pool TVL by converting each amount with its token's actual decimals rather than hardcoding 18. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ools poolManager.totalValueLockedETH/USD was being set before the pseudoTotalValueLocked override, so it accumulated the swap-delta-based pool TVL instead of the hook-reported value. Move the poolManager update to after the aggregator override block. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
matteenm
reviewed
Feb 19, 2026
Comment on lines
+197
to
+198
| poolManager.totalValueLockedETH = poolManager.totalValueLockedETH.plus(pool.totalValueLockedETH) | ||
| poolManager.totalValueLockedUSD = poolManager.totalValueLockedETH.times(bundle.ethPriceUSD) |
Collaborator
There was a problem hiding this comment.
so here we're saying that external liquidity that is accessible by v4 hooks should count as poolManager liquidity, even though technically it's not value locked in the pool manager?
Collaborator
There was a problem hiding this comment.
(not that i have a strong opinion on this, i think there is an argument that it should include it.)
Contributor
Author
There was a problem hiding this comment.
ah yeah that makes sense, probably should just forgoe it
matteenm
reviewed
Feb 19, 2026
Comment on lines
+191
to
+192
| token0.totalValueLockedUSD = token0.totalValueLocked | ||
| token1.totalValueLockedUSD = token1.totalValueLocked |
Collaborator
There was a problem hiding this comment.
token level tvl will not include the external liquidity?
ciyengar3
changed the title
ciyengar3
force-pushed
the
tempo-testnet
branch
from
8a5a81b to
12dafe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.