feat: desaturate & opacity for unapproved tokens #52
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } | ||
|
|
||
| export default styled(TokenImg)<{ size?: number }>` | ||
| export default styled(TokenImg)<{ size?: number; unapproved?: boolean }>` |
There was a problem hiding this comment.
call this approved do the name doesn't include a boolean modifier
There was a problem hiding this comment.
chose to use unapproved so that the default tokenImg isn't unapproved and shows in full saturation; you'd have to explicitly set a tokenImg as unapproved
There was a problem hiding this comment.
If I'm reading the code correctly, it looks like approvalState is this enum:
export enum ApprovalState {
UNKNOWN = 'UNKNOWN',
NOT_APPROVED = 'NOT_APPROVED',
PENDING = 'PENDING',
APPROVED = 'APPROVED',
}
Would you not get the desired behavior if you just pass down approval state to the style, then make the decision about saturation there?
like:
${({ approvalState }) => approvalState === ApprovalState.NOT_APPROVED && 'filter: grayscale(100%) opacity(60%)'}
zzmp
left a comment
zzmp
left a comment
There was a problem hiding this comment.
This is already done in https://github.com/Uniswap/widgets/blob/main/src/components/Swap/Input.tsx#L38-L41.
Is this meant to replace that? Could this instead be done by copying or re-using the Input.tsx code for Output.tsx?
| height: ${({ size }) => size || 1}em; | ||
| width: ${({ size }) => size || 1}em; | ||
| ${({ unapproved }) => unapproved && 'filter: grayscale(100%) opacity(60%)'} |
There was a problem hiding this comment.
use 'saturate(0) opacity(0.4)' instead (I may have the opacity value wrong, but this is what is already in the code). Desaturation is the stated goal, so saturate is more semantic than grayscale.
| } | ||
|
|
||
| export default function TokenButton({ value, collapsed, disabled, onClick }: TokenButtonProps) { | ||
| export default function TokenButton({ value, collapsed, disabled, isUnapprovedToken, onClick }: TokenButtonProps) { |
There was a problem hiding this comment.
Same - use approved: boolean or approval: ApprovalState.
There was a problem hiding this comment.
Whatever you use here should be passed directly to TokenImg.
If token has not yet been approved, desaturate & change opacity of the token logo:
Unapproved:
Approved:
