Skip to content

fix: mitigate ReDoS in regex validation (CVE-2025-5891) #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohitxroxx wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: mitigate ReDoS in regex validation (CVE-2025-5891) #6087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions lib/tools/Config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,26 @@ Config._valid = function(key, value, sch){
}

// Verify maximum / minimum of Number value.
if (type == '[object Number]') {
if (this._error(typeof sch.max != 'undefined' && value > sch.max, 'max', key, sch.max, value)) {
if (type === '[object String]' && sch.regex) {

// Preventing heavy RegExp from ReDoS attack.
if (value.length > 1024) {
this._errors.push(`"${key}" exceeds maximum allowed length`);
return null;
}
if (this._error(typeof sch.min != 'undefined' && value < sch.min, 'min', key, sch.min, value)) {

let regex;
try {
regex = sch._compiledRegex || (sch._compiledRegex = new RegExp(sch.regex));
} catch (err) {
this._errors.push(`Invalid regex for "${key}"`);
return null;
}
}

if (!regex.test(value)) {
return null;
}
}
// If first type is Array, but current is String, try to split them.
if(scht.length > 1 && type != scht[0] && type == '[object String]'){
if(scht[0] == '[object Array]') {
Expand Down