fix: pm2 flush reports error for nonexistent process#6098
Open
YoanWai wants to merge 1 commit intoUnitech:masterfrom
Open
fix: pm2 flush reports error for nonexistent process#6098YoanWai wants to merge 1 commit intoUnitech:masterfrom
YoanWai wants to merge 1 commit intoUnitech:masterfrom
Conversation
|
|
When pm2 flush is called with an app name or id that does not match any running process, it previously printed "Logs flushed" even though nothing was actually flushed. This is misleading. Now it prints an error and returns an error callback when the specified process is not found. Also adds tests for pm_id-based flushing and the not-found error case. Closes Unitech#4553
YoanWai
force-pushed
the
fix/flush-specific-app
branch
from
28696c5 to
64a9e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pm2 flush <app_name>orpm2 flush <app_id>targets a process that does not exist, PM2 now prints an error instead of silently printing "Logs flushed"foundflag to track whether any process matched the given name/idPreviously, running
pm2 flush nonexistentwould print[PM2] Logs flushedeven though no logs were actually flushed, giving the user misleading feedback.Test plan
npm testpasses (flush.mocha.js)Closes #4553