FIX: [ISXB-1650] Fixed an issue where the action icon would shrink or disappear from UI when an action has a very long name. #2266
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disappear from UI when an action has a very long name.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
![u-pr-agent[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| <ui:VisualElement name="icon" class="tree-view-item-icon" style="height: 19px; -unity-background-scale-mode: scale-to-fit;" /> | ||
| <ui:TextField picking-mode="Ignore" name="rename-text-field" is-delayed="true" focusable="true" class="unity-input-actions-editor-hidden" style="visibility: visible; flex-shrink: 1;" /> | ||
| <ui:Label text="binding-name" display-tooltip-when-elided="true" name="name" style="flex-grow: 1; justify-content: center; align-items: stretch; margin-left: 4px; -unity-font-style: normal;" /> | ||
| <ui:Label text="binding-name" display-tooltip-when-elided="true" name="name" style="flex-grow: 1; flex-shrink: 1; justify-content: center; align-items: stretch; margin-left: 4px; -unity-font-style: normal;" /> |
There was a problem hiding this comment.
Suggestion: While adding flex-shrink: 1 allows the label to shrink, it may not shrink below its minimum content size with very long text. To ensure it can shrink sufficiently and not crowd out other elements, consider adding min-width: 0. This is a common flexbox pattern for handling long content in flexible items. [general, importance: 6]
Suggested change
| <ui:Label text="binding-name" display-tooltip-when-elided="true" name="name" style="flex-grow: 1; flex-shrink: 1; justify-content: center; align-items: stretch; margin-left: 4px; -unity-font-style: normal;" /> | |
| style="flex-grow: 1; flex-shrink: 1; min-width: 0; justify-content: center; align-items: stretch; margin-left: 4px; -unity-font-style: normal;" |
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent
ritamerkl
approved these changes
Oct 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2266 +/- ##
===========================================
+ Coverage 76.70% 76.81% +0.10%
===========================================
Files 465 476 +11
Lines 87919 88645 +726
===========================================
+ Hits 67442 68093 +651
- Misses 20477 20552 +75 Flags with carried forward coverage won't be shown. Click here to find out more. see 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the action icon would shrink or disappear from UI when an action has a very long name reported here: https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1650. Additionally this issue also resulted in inconsistent behaviour between rename and display modes.
I have not attempted to clean up the UXML and move all styling to USS in this PR.
Testing status & QA
Verified during development by visual inspection when adding very long names that won't fit the available bounds.
Overall Product Risks
Comments to reviewers
Solves only by styling constraints.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: