-
Notifications
You must be signed in to change notification settings - Fork 332
FIX: Input System actions not auto-saving in Project Settings when both related windows were open #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josepmariapujol-unity
wants to merge
17
commits into
develop
Choose a base branch
from
input/save-asset-input-system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−1
Open
FIX: Input System actions not auto-saving in Project Settings when both related windows were open #2362
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
355f77c
Implementing Save button in input system settings
josepmariapujol-unity 826e5a2
Update InputActionsEditorView.cs
josepmariapujol-unity 49d95ac
Update InputActionsEditorView.cs
josepmariapujol-unity 2fc1958
Using Save() method both InputActionsEditorSettingsProvider.cs & Inpu…
josepmariapujol-unity e9b0e08
Add asset verification before saving input actions
josepmariapujol-unity e3a124c
Fix saving InputSystem actions in ProjectSettings
josepmariapujol-unity 61ef1ef
Remove XML comments from Save method
josepmariapujol-unity 65f1767
Refactor Save method position in InputActionsEditorWindow
josepmariapujol-unity 7e2617c
Merge branch 'develop' into input/save-asset-input-system
josepmariapujol-unity 80b37e3
Adding a conditional when projectSettingsWindowIsOpen is NOT open
josepmariapujol-unity f5eea5f
Reverting commit changes
josepmariapujol-unity 598835e
Update InputActionsEditorWindow.cs
josepmariapujol-unity 7c08c13
Update InputActionsEditorWindow.cs
josepmariapujol-unity 92fb34b
Refactor condition in InputActionsEditorSettingsProvider
josepmariapujol-unity 1359613
Remove unused variable in InputActionsEditorSettingsProvider
josepmariapujol-unity 5c2eab5
Update CHANGELOG.md
josepmariapujol-unity 16ff070
Add helpbox to asset assigned as the Project-wide Input Actions
josepmariapujol-unity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking my understanding of the repo, so currently tested scenario is:
Expected: InputActionAsset reflect the change from the PWIA auto save.
What would happen given the opposite scenario?
Expected: I assume that this should do nothing as the instance of PWIA is not dirty and skip auto save, but might be worth a quick try.
Alt Expected:
My assumption is that the PWIA is now auto saving and gaining priority over any unsaved work you do in the other window. This sounds like expected behaviour, but: