fix(#587): noise problems when using Android microphone#1121
Open
rollersteaam wants to merge 1 commit intoUnity-Technologies:mainfrom
Open
fix(#587): noise problems when using Android microphone#1121rollersteaam wants to merge 1 commit intoUnity-Technologies:mainfrom
rollersteaam wants to merge 1 commit intoUnity-Technologies:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioProcessing::Configso it is actually applied when processing audio from the Android microphoneUnityAudioTrackSourceto route audio frames through WebRTC's built-in Audio Processing Module (APM)Motivation
Fixes #587. Android microphones produce extremely noisy audio due to hardware characteristics. While WebRTC's APM supports noise suppression, it was not being applied because audio frames were not being routed through the APM pipeline in the plugin's C++ layer.
Test plan
🤖 Generated with Claude Code