fix(ui): replace dlgs dialogs with zenity#616
Merged
davidnewhall merged 2 commits intoUnpackerr:mainfrom Mar 12, 2026
Merged
Conversation
Addresses Unpackerr#608 by switching GUI dialog wrappers from github.com/gen2brain/dlgs to github.com/ncruces/zenity.
Collaborator
|
Thanks for this. Saves me a few tokens.
That's fully expected and why the official build uses macOS and not a cross-compile - it doesn't work. Perhaps I'll find a better systray library to make this better. something like this github.com/energye/systray |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/gen2brain/dlgswithgithub.com/ncruces/zenityin the GUI dialog wrapper (pkg/ui/dlgs.go)bool,errorandstring,bool,error), including mapping canceled dialogs took=falsewithout surfacing an errorgithub.com/ncruces/zenityValidation
go test ./pkg/uigo test ./pkg/unpackerr -run TestDoesNotExistGOOS=windows GOARCH=amd64 go test ./pkg/uigit diff --checkNotes
GOOS=darwin GOARCH=amd64 go test ./pkg/uicurrently fails in this Windows environment due to existinggithub.com/getlantern/systraydarwin build limitations (nativeLoop/registerSystrayunresolved). The zenity wrapper changes compile and test on native host + windows cross-compile.