feat: Add binary_encode_vectors flag to AstraDBUploader #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AstraDB uploads vectors with their own binary format by default. This is more efficient, but it makes it hard to view and work with vectors directly in the UI. We can add a flag to turn off this encoding if you're willing to take the performance hit.
Tried adding an integration test, but vectors are also read in binary format so this doesn't verify anything. Instead, let's start a unit test suite for Astra to confirm that the option is being set.
Note
Adds
binary_encode_vectorsflag toAstraDBUploaderto optionally disable binary-encoded vectors and adds unit tests; bumps version to 1.2.22.binary_encode_vectors(defaultTrue) toAstraDBUploaderConfig.AstraDBUploader.run_data, whenbinary_encode_vectors=False, applyastrapyAPIOptions/SerdesOptionsviawith_optionsto disable binary encoding before inserts.test_astradb.pyverifyingwith_optionsusage when disabled and no call by default.__version__to1.2.22.CHANGELOG.mdwith the new feature.Written by Cursor Bugbot for commit e4515c7. This will update automatically on new commits. Configure here.