feat: add linux extra readable mounts for cross-mount visibility#62
Open
feat: add linux extra readable mounts for cross-mount visibility#62
Conversation
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/sandbox/linux.go">
<violation number="1" location="internal/sandbox/linux.go:655">
P2: Appending `extraReadableMountPaths` last can cause explicit mount roots to be skipped when earlier child paths mark the root as already bound. Process extra mount roots first so their bind is not dropped by intermediary-dir bookkeeping.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement non-recursive bubblewrap root binds by introducing
filesystem.extraReadableMounts. This lets users explicitly expose mount roots (for example/nixand/run) while keeping defaults conservative.Changes
filesystem.extraReadableMountsand wire it through config loading/merge, JSON output, and schema generation.internal/sandbox/linux_mounts.go:/proc/self/mountinfo/dev,/proc,/tmp) to avoid conflicts.internal/sandbox/linux.gointernal/sandbox/linux_landlock.go.extraReadableMountsentries are absolute paths (must start with/).extraReadableMountswith a NixOS example/nix/store/... -> /nix,/run/... -> /run).