Skip to content

Refresh visual theme foundation#606

Open
gioalex07 wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07:main
Open

Refresh visual theme foundation#606
gioalex07 wants to merge 3 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07:main

Conversation

@gioalex07
Copy link
Copy Markdown

Summary

  • Refresh the app visual foundation with a more modern Material 3 styled XML theme.
  • Improve overall readability, contrast, and surface consistency without changing app behavior.

What does this implement/fix?

  • Updates the base app theme and styling in app/src/main/res/values/styles.xml.
  • Introduces a semantic day/night color palette in app/src/main/res/values/colors.xml and app/src/main/res/values- night/colors.xml.
  • Refreshes the main visual shell in:
    • app/src/main/res/layout/main_activity.xml
    • app/src/main/res/layout/main_content.xml
    • app/src/main/res/layout/main_toolbar.xml
    • app/src/main/res/layout/main_navigation.xml
    • app/src/main/res/layout/main_connection.xml
  • Updates navigation selection visuals in:
    • app/src/main/res/drawable/menu_selector.xml
    • app/src/main/res/drawable/navigation_drawer_item_background.xml

This is a small and focused UI foundation change. It does not intentionally modify app logic, navigation behavior, or
Wi-Fi analysis functionality.

Does this close any issues?

  • Related to improving the visual design and usability of the app.

How was this tested?

  • Devices / OS:
    • Pixel 6 emulator
  • Platform / Build variant:
    • Debug
  • Toolchain / Gradle / SDK version(s):
    • JDK 21
    • Gradle 9.3.1
    • Android Gradle Plugin 9.0.0
    • compileSdk 36
    • buildTools```md

Summary

  • Refresh the app's visual theme foundation with a more modern Material 3 styled XML setup.
  • Improve overall visual consistency, contrast, and spacing without changing app behavior.

What does this implement/fix?

  • Updates the base theme in app/src/main/res/values/styles.xml to use a Material 3 DayNight foundation while
    preserving the current XML/View-based architecture.
  • Introduces a semantic light/dark color palette in app/src/main/res/values/colors.xml and app/src/main/res/values- night/colors.xml.
  • Refreshes core chrome and containers:
    • app/src/main/res/layout/main_activity.xml
    • app/src/main/res/layout/main_content.xml
    • app/src/main/res/layout/main_toolbar.xml
    • app/src/main/res/layout/main_navigation.xml
    • app/src/main/res/layout/main_connection.xml
  • Updates navigation selection styling in app/src/main/res/drawable/menu_selector.xml.
  • Adds a new drawer item background resource in app/src/main/res/drawable/navigation_drawer_item_background.xml.

This is a small and focused visual foundation change. It does not modify app logic, navigation flow, or public APIs.

Does this close any issues?

  • Related to improving the app visual design and reducing legacy UI feel.

How was this tested?

  • Devices / OS: Pixel 6 emulator, Android emulator environment
  • Platform / Build variant: debug
  • Toolchain / Gradle / SDK version(s):
    • JDK 21
    • Gradle 9.3.1
    • compileSdk 36
    • buildTools 36.1.0
  • Steps to reproduce / test:
    1. Open the project in Android Studio.
    2. Sync Gradle files.
    3. Run the app on a Pixel 6 emulator.
    4. Verify the updated toolbar, drawer, bottom navigation, and main surfaces in the app.
    5. Switch between available themes and confirm visual consistency.

Example test commands:

./gradlew assembleDebug
./gradlew ktlintCheck
./gradlew testDebugUnitTest

## Checklist (required before marking ready)

- [ ] I added or updated unit tests (see app/src/test/)
- [x] I followed the project's coding style (ktlint) and formatting
- [ ] I ran lint and addressed or documented any warnings
- [x] CI checks pass (unit tests, coverage, lint)
- [x] No sensitive data, keys, or secrets are included

## Additional context

- This PR is intentionally limited to visual foundation work so it can be reviewed independently before making deeper
  UI updates.
- Manual visual verification was performed in the emulator and the updated foundation loaded correctly.

## Reviewer notes

- Please focus review on theme/resource compatibility and visual consistency across light/dark/black modes.
- No functional behavior changes are intended in this PR.
- Suggested reviewers or teams (optional): @maintainers

@VREMSoftwareDevelopment
Copy link
Copy Markdown
Owner

Thanks for the contribution.

  1. AI Usage Disclosure
    Disclose any AI tool involvement and use the “AI assistance used” label.

  2. Testing Requirements
    Changes must be tested on a real Android device.
    Emulator‑only testing or running build tasks (e.g., ktlintCheck, unit tests, successful Gradle build) is not sufficient.
    UI/UX behavior, layouts, gestures, and rendering often differ between emulators and actual devices.

Please update the PR with real‑device testing details so review can continue.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (bd25b4d) to head (1dc9487).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #606   +/-   ##
=========================================
  Coverage     97.83%   97.83%           
  Complexity      975      975           
=========================================
  Files           121      121           
  Lines          2581     2581           
  Branches        211      211           
=========================================
  Hits           2525     2525           
  Misses           19       19           
  Partials         37       37           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gioalex07
Copy link
Copy Markdown
Author

AI Usage Disclosure

  • AI assistance was used to help inspect the existing theme/layout structure and draft part of the resource updates.
  • All changes were manually reviewed, adjusted, built, and tested before submission.

How was this tested?

  • Devices / OS:
    • Samsung Galaxy A30, Android 11
    • Pixel 6 emulator
  • Platform / Build variant: debug
  • Toolchain / Gradle / SDK version(s):
    • JDK 21
    • Gradle 9.3.1
    • compileSdk 36
    • buildTools 36.1.0
  • Steps to reproduce / test:
    1. Open the project in Android Studio.
    2. Run the app on a Samsung Galaxy A30 physical device.
    3. Open the main screens: Access Points, Channel Rating, Channel Graph, and Time Graph.
    4. Open the navigation drawer and verify the selected state styling.
    5. Verify toolbar, bottom navigation, and connection panel rendering.
    6. Switch themes and confirm visual consistency and readability.

@VREMSoftwareDevelopment VREMSoftwareDevelopment added the AI assistance used Indicates that an AI assistant was used to generate this PR label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assistance used Indicates that an AI assistant was used to generate this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants