Skip to content

RFC 7208: 5.2, none result should be returned as "no match" #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmeij wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC 7208: 5.2, none result should be returned as "no match" #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/coppertone/mechanism/include_matcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ def evaluate_fail_result(result, _m, _r)
result
end

def evaluate_none_result(result, m, r)
new_result = super
return new_result unless new_result.none?
# RFC 7208: 5.2, none result should be returned as "no match"
# def evaluate_none_result(result, m, r)
# new_result = super
# return new_result unless new_result.none?

raise Coppertone::NoneIncludeResultError
end
# raise Coppertone::NoneIncludeResultError
# end
end

attr_reader :record
Expand Down