Skip to content

Conversation

@dkurschner1
Copy link

I just realized I missed the point of tests. I wrote tests for both features requested instead of one at a time. But I did write the tests before I wrote code to make it pass.

@Vandise
Copy link
Owner

Vandise commented Feb 21, 2018

5 points per:

  • You clone this repository and perform the work specified in your own repository.
  • You submit a pull request on Github
  • Your pull request contains modified versions of the class and the unit test
  • The test cases pass.
  • You have implemented new methods to make the tests pass.
  • Your code is free from errors
  • Your code is well formed, correct, and efficient.

10 points per:

  • Your Git commit history in your project shows that you developed the tests first. That means you will have multiple commits. You must use Git to demonstrate to me that tests were written before code was implemented.
Instructor comments:

You wrote unit tests first, but not in the TDD style.
Write a test to check the minimum functionality of a class or method.
  • Make sure you follow the rules of TDD:
  • Do not write any code unless it’s to make a failing test pass.
  • Do not write any more of a unit test than is sufficient to fail, and not compiling is failing.
  • Do not write more code than you need to make the current unit test pass.
Instructor comments:

Minimum functionality is the main emphasis of TDD. You wrote complete tests, but also had
to write a lot of code to support the tests -- this is not TDD.

Overall, well done! You've shown me you're understanding the concepts of TDD,
but jumped a little too far ahead.

Check E360 for your Grade as an unchecked box does not mean you were not given any points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants