TDD Assessment

[byang32]

My TDD Assessment complete

[Vandise]

5 points per:

• You clone this repository and perform the work specified in your own repository.
• You submit a pull request on Github
• Your pull request contains modified versions of the class and the unit test
• The test cases pass.
• You have implemented new methods to make the tests pass.
• Your code is free from errors
• Your code is well formed, correct, and efficient.

10 points per

• Your Git commit history in your project shows that you developed the tests first. That means you will have multiple commits. You must use Git to demonstrate to me that tests were written before code was implemented.

You committed your tests and implemented methods at the same time (they never failed
according to your git history)

https://github.com/Vandise/agile_fall_2017_tdd/pull/25/commits/91426fbaceb66dc52cc1299efcf4e2166d23f21e

empty test?
https://github.com/Vandise/agile_fall_2017_tdd/pull/25/commits/0c52292792b9138ae2f3cf9a4ae6eeaea1a36921

Why did you write new code when you had a failing unit test?
https://github.com/Vandise/agile_fall_2017_tdd/pull/25/commits/376806528edad82247d8103a32af7c507da36503

• Make sure you follow the rules of TDD:
• Do not write any code unless it’s to make a failing test pass.
• Do not write any more of a unit test than is sufficient to fail, and not compiling is failing.
• Do not write more code than you need to make the current unit test pass.

See above comments, my primary concern is in regards to this commit:
https://github.com/Vandise/agile_fall_2017_tdd/pull/25/commits/376806528edad82247d8103a32af7c507da36503

which breaks your unit tests and it was committed.

Instructor comments:

Check E360 for your Grade as an unchecked box does not mean you were not given any points,
a checked box doesn't mean you were given full points.