Skip to content

[Staking][GUI] Unlock wallet for staking dialogue on click #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeofalltrades merged 1 commit into from
Apr 26, 2021
Merged

[Staking][GUI] Unlock wallet for staking dialogue on click #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 34 additions & 20 deletions src/qt/veil/veilstatusbar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,27 +119,41 @@ void VeilStatusBar::onCheckStakingClicked(bool res) {

// Miner thread starts in init.cpp, but staking enabled flag is checked each iteration of the miner, so can be enabled or disabled here
WalletModel::EncryptionStatus lockState = walletModel->getEncryptionStatus();
if (res){
if (gArgs.GetBoolArg("-exchangesandservicesmode", false) || lockState == WalletModel::Locked) {
QString dialogMsg = gArgs.GetBoolArg("-exchangesandservicesmode", false) ? "Staking is disabled in exchange mode" : "Must unlock wallet before staking can be enabled";
openToastDialog(dialogMsg, mainWindow);
fBlockNextStakeCheckSignal = true;
ui->checkStaking->setChecked(false);
setStakingText();
return;
}else{
this->walletModel->setStakingEnabled(true);
mainWindow->updateWalletStatus();
openToastDialog("Staking enabled", mainWindow);
setStakingText();
}
} else {
this->walletModel->setStakingEnabled(false);
mainWindow->updateWalletStatus();
openToastDialog("Staking disabled - this may take a few minutes", mainWindow);
setStakingText();
}

if (gArgs.GetBoolArg("-exchangesandservicesmode", false)) {
QString dialogMsg = "Staking is disabled in exchange mode";
openToastDialog(dialogMsg, mainWindow);
fBlockNextStakeCheckSignal = true;
ui->checkStaking->setChecked(false);
setStakingText();
return;
} else if (lockState == WalletModel::Locked) {
QString dialogMsg = "Must unlock wallet before staking can be enabled";
openToastDialog(dialogMsg, mainWindow);
fBlockNextStakeCheckSignal = true;
ui->checkStaking->setChecked(false);
setStakingText();

mainWindow->showHide(true);
UnlockPasswordDialog *dialog = new UnlockPasswordDialog(/*fUnlockForStakingOnly*/true, this->walletModel, mainWindow);
if(openDialogWithOpaqueBackground(dialog, mainWindow, 4)){
openToastDialog("Wallet unlocked for staking", mainWindow);
}else{
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 Apr 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Follow consistent spacing to rest of the module (space between code and brackets

if () {
} else {

etc...

openToastDialog("Wallet not unlocked for staking", mainWindow);
}
}else{
if(!this->walletModel->isStakingEnabled()){
this->walletModel->setStakingEnabled(true);
mainWindow->updateWalletStatus();
openToastDialog("Enabling staking - this may take a few minutes", mainWindow);
setStakingText();
}else {
this->walletModel->setStakingEnabled(false);
mainWindow->updateWalletStatus();
openToastDialog("Disabling staking - this may take a few minutes", mainWindow);
setStakingText();
}
}
}

bool fBlockNextBtnLockSignal = false;
Expand Down