[VEN-3018]: Initial Risk Steward contract #115
Conversation
coreyar
requested review from
Debugger022,
GitGuru7,
chechu,
kkirka and
web3rover
coreyar
force-pushed
the
acm-risk-steward
branch
from
e17395f to
1fcc60b
Compare
coreyar
force-pushed
the
acm-risk-steward
branch
4 times, most recently
from
0d56e60 to
c9fa6c4
Compare
chechu
changed the title
coreyar
force-pushed
the
acm-risk-steward
branch
4 times, most recently
from
b581081 to
16ed613
Compare
coreyar
force-pushed
the
acm-risk-steward
branch
from
a03a723 to
24908dd
Compare
coreyar
force-pushed
the
acm-risk-steward
branch
3 times, most recently
from
9e7c889 to
b73301f
Compare
…e-contracts into acm-risk-steward
| * @dev Disabling renounceOwnership function. | ||
| */ | ||
| function renounceOwnership() public override { | ||
| revert(" renounceOwnership() is not allowed"); |
| function _setMarketSupplyCaps(address[] calldata, uint256[] calldata) external; | ||
|
|
||
| function _setMarketBorrowCaps(address[] calldata, uint256[] calldata) external; | ||
| } |
There was a problem hiding this comment.
If this PR would merge before this one, then we can have unified comptroller interface.
There was a problem hiding this comment.
Let's use the legacy interface first, and the new one in the V2/V3 of the Risk Stewards
deploy/011-risk-stewards.ts
Outdated
| proxyContract: "OptimizedTransparentUpgradeableProxy", | ||
| execute: { | ||
| methodName: "initialize", | ||
| args: [accessControlManager.address, 5000], |
There was a problem hiding this comment.
Consider replacing the hardcoded value 5000 with a constant or variable — this improves readability and makes future changes easier
| /** | ||
| * @notice Emitted when the max delta bps is updated | ||
| */ | ||
| event MaxDeltaBpsUpdated(uint256 oldMaxDeltaBps, uint256 indexed newMaxDeltaBps); |
There was a problem hiding this comment.
add indexed for oldMaxDeltaBps as well for consistency.
| * @param newValue The new supply cap value | ||
| * @custom:event Emits SupplyCapUpdated with the market and new supply cap | ||
| */ | ||
| function _updateSupplyCaps(address market, uint256 newValue) internal { |
There was a problem hiding this comment.
we can add ensureNonzeroAddress(market) as safety validation .
| * @param newValue The new borrow cap value | ||
| * @custom:event Emits BorrowCapUpdated with the market and new borrow cap | ||
| */ | ||
| function _updateBorrowCaps(address market, uint256 newValue) internal { |
There was a problem hiding this comment.
we can add ensureNonzeroAddress(market) as safety validation .
| /** | ||
| * @notice Thrown when an update type that is not supported is operated on | ||
| */ | ||
| error UnsupportedUpdateType(); |
There was a problem hiding this comment.
error UnsupportedUpdateType(string updateType) , this will upgrade the revert to revert UnsupportedUpdateType(update.updateType);
helpers/deploy/deploymentUtils.ts
Outdated
| zksyncmainnet: "", | ||
| berachainbartio: "", | ||
| berachainbepolia: "", | ||
| }[networkName]; |
There was a problem hiding this comment.
need to fill contract addresses for remaining chains if needed or remove it .
Description
This is an initial Risk Steward contract that accepts updates for supply and borrow caps to be applied view permissions granted by the ACM.