[VEN-2984] Flash loan implementation #460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugger022
changed the title
Debugger022
changed the title
Debugger022
requested review from
GitGuru7,
chechu,
kkirka and
web3rover
and removed request for
GitGuru7,
kkirka and
web3rover
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
web3rover
reviewed
Jun 26, 2025
| ) external override nonReentrant returns (uint256) { | ||
| ensureNonzeroAddress(receiver); | ||
|
|
||
| IFlashLoanSimpleReceiver receiverContract = IFlashLoanSimpleReceiver(msg.sender); |
Collaborator
There was a problem hiding this comment.
Should it be receiver instead of msg.sender
Collaborator
Author
There was a problem hiding this comment.
The initiator could be a different address of receiver, it would be more safe to use msg.sender .
web3rover
reviewed
Jun 26, 2025
fred-venus
force-pushed
the
develop
branch
4 times, most recently
from
5beda80 to
6ab87cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the implementation of flashloan functionality for isolated pools. Flashloan enable users to borrow assets without collateral, provided the loan is repaid within the same transaction. This enhancement includes the following changes:
Flashloan Implementation: Added flashloan capability to isolated pools, allowing borrowing and repayment in a single transaction.
Mock Receiver Contract: Introduced a mock receiver contract for testing purposes, which handles the flashloan receipt and repayment.
Test Cases: Comprehensive unit tests for the flashloan logic, including tests for successful execution, edge cases, and failure scenarios.
Deployment Script: Updated the deployment script to accommodate the new flashloan functionality for isolated pools.
Contract Updates: Modified relevant contracts to integrate the flashloan feature while ensuring compatibility with existing logic and maintaining security checks.