Skip to content

[VPD-280]: BNB Hardfork - Fermi Upgrade #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Debugger022 merged 3 commits into from
Dec 11, 2025
Merged

[VPD-280]: BNB Hardfork - Fermi Upgrade #638

Debugger022 merged 3 commits into from
Dec 11, 2025

Conversation

@Debugger022
Copy link
Contributor

@Debugger022 Debugger022 commented Nov 17, 2025 •
edited
Loading

This VIP is a follow-up to the #637 to upgrade the implementations of contracts and reward emission speeds for both the isolated and core pools.

BNB Announcement

@Debugger022 Debugger022 self-assigned this Nov 17, 2025
Exef
Exef previously approved these changes Nov 20, 2025
View reviewed changes
@Debugger022
Copy link
Contributor Author

Debugger022 commented Nov 30, 2025

Currently, the testnet is completed. Need to work on Mainnet.

@Debugger022 Debugger022 added the BNB Fermi Upgrade https://docs.bnbchain.org/announce/fermi-bsc/ label Nov 30, 2025
fred-venus
fred-venus reviewed Dec 2, 2025
View reviewed changes
fred-venus
fred-venus reviewed Dec 2, 2025
View reviewed changes
fred-venus
fred-venus reviewed Dec 2, 2025
View reviewed changes
vips/vip-572/bsctestnet.ts
{
target: BSCTESTNET_VTOKEN_BEACON,
signature: "upgradeTo(address)",
params: [BSCTESTNET_NEW_VTOKEN_IMPLEMENTATION],
Copy link
Contributor

@fred-venus fred-venus Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is it for testnet only, i checked mainnet, the implementation seems completely different

fred-venus
fred-venus reviewed Dec 2, 2025
View reviewed changes
@fred-venus
Copy link
Contributor

fred-venus commented Dec 2, 2025 •
edited
Loading

any context why is RewardsDistributor omitted
CleanShot 2025-12-02 at 17 00 51@2x

@Debugger022
Copy link
Contributor Author

Debugger022 commented Dec 2, 2025

#638 (comment)
We have updated this implementation for the isolated pools, as it accepts blocksPerYear in the vToken constructor. We will do the same for mainnet.

@Debugger022
Copy link
Contributor Author

Debugger022 commented Dec 2, 2025

#638 (comment)
I think that we should update it, but we haven't updated the rewards distributor in the Maxwell upgrade.
@GitGuru7, do you know the reason behind it?

@GitGuru7
Copy link
Contributor

GitGuru7 commented Dec 3, 2025

#638 (comment) I think that we should update it, but we haven't updated the rewards distributor in the Maxwell upgrade. @GitGuru7, do you know the reason behind it?

we had skipped it because blocksOrSecondsPerYear is not being used anywhere in the contract, but we can update now to keep things consistent. You would need to update the speed for existing rewards as well, if there are any.

@fred-venus
Copy link
Contributor

fred-venus commented Dec 4, 2025

#638 (comment) I think that we should update it, but we haven't updated the rewards distributor in the Maxwell upgrade. @GitGuru7, do you know the reason behind it?

we had skipped it because blocksOrSecondsPerYear is not being used anywhere in the contract, but we can update now to keep things consistent. You would need to update the speed for existing rewards as well, if there are any.

Can i understand this way

  1. RewardsDistributor is a contract to distribute reward in the form of reward token (including but not limited to XVS)

  2. adding TimeManagerV8 as its base contract is more like a future proof

  3. " You would need to update the speed for existing rewards " -> as far as i know, i don't see any on our page?

fred-venus
fred-venus reviewed Dec 4, 2025
View reviewed changes
@Debugger022
Copy link
Contributor Author

Debugger022 commented Dec 8, 2025

testnet execution: https://testnet.bscscan.com/tx/0x857d98b12dd3e51446b65a13c6b4c06469516db98f27317017e26c86ff776a8a

@Debugger022
Copy link
Contributor Author

Debugger022 commented Dec 8, 2025

This VIP has been executed to update the VToken implementation in the isolated pools to correct the value of the MAX_BORROW_RATE_MANTISSA, which was set incorrectly in the previous deployment.

testnet-addendum execution: https://testnet.bscscan.com/tx/0x322b19f699649ac2e4de0e0ce183d10135fb4f718d7caa23b9fc75231235f3aa

@Debugger022 Debugger022 merged commit 616724d into main Dec 11, 2025
2 checks passed
@fred-venus fred-venus mentioned this pull request Dec 11, 2025
Merged
@fred-venus
Copy link
Contributor

fred-venus commented Dec 11, 2025

Updated the vip num to 778 in #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Exef Exef Exef approved these changes

@fred-venus fred-venus fred-venus approved these changes

Assignees

@Debugger022 Debugger022

Labels

BNB Fermi Upgrade https://docs.bnbchain.org/announce/fermi-bsc/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Debugger022 @fred-venus @GitGuru7 @Exef