Optional Clientv2 API #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkaeding
pushed a commit
to pkaeding/Dynamoid
that referenced
this pull request
Jun 3, 2014
This accepts PR Veraticus#154 Conflicts: lib/dynamoid/adapter.rb lib/dynamoid/document.rb
|
Is there any word on when this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new adapter that uses V2 DynamoDB Client API. In the future, this should make it possible to add secondary index support (though this PR doesn't include it) as well as enable the use of newer versions of fake_dynamo.
I implemented as-needed until all specs passed, and I endeavored to make zero non-adapter changes, effectively keeping the interface to the upper layers of Dynamoid fixed. Thus, it is likely that the functionality is incomplete and/or lacking performance. Additionally, many sections of code are quite ugly, so once Dynamo is migrated to this interface, there will need to be successive rounds of cleanup where code is simplified by tweaking the adapter interface to the upper layers of software.
I'll continue to clean up the code a bit, and eventually merge it as an optional adapter before making it permanent.