Skip to content

fix: Fix capture operations (#26)#27

Merged
OlegoO merged 2 commits intodevfrom
VCST-4782
Mar 18, 2026
Merged

fix: Fix capture operations (#26)#27
OlegoO merged 2 commits intodevfrom
VCST-4782

Conversation

@OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Mar 18, 2026

Description

fix: Fixed capture URL - an incorrect one was used.
fix: Fixed Payment.Capture creation. Capture shouldn't be created if a payment is only authorized, not settled
fix: Added support for airlineData payload

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4782

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Datatrans_3.802.0-pr-27-bd34.zip


Note

Medium Risk
Changes the Datatrans capture/settlement endpoint and alters when/what capture records are created, which can affect payment state transitions and reconciliation.

Overview
Fixes Datatrans capture calls to use the correct POST /v1/transactions/{id}/settle endpoint instead of /capture.

Extends capture requests to optionally include airlineData, adding a RawJsonConverter so JSON strings are embedded as raw objects/arrays in the payload.

Adjusts payment capture bookkeeping: capture operations now append a Capture record on successful settle, and post-processing no longer creates a Capture entry when the transaction is only Authorized (not settled).

Written by Cursor Bugbot for commit bd346bf. This will update automatically on new commits. Configure here.

fix: Fixed capture URL - an incorrect one was used.
fix: Fixed Payment.Capture creation. Capture shouldn't be created if a payment is only authorized, not settled
fix: Added support for airlineData payload
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.333
Timestamp: 18-03-2026T10:10:00

@sonarqubecloud
Copy link

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.941
Timestamp: 18-03-2026T11:34:44

@OlegoO OlegoO merged commit cfe0b11 into dev Mar 18, 2026
8 checks passed
@OlegoO OlegoO deleted the VCST-4782 branch March 18, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants