Skip to content

Deprecate Hyak PBS/Torque scheduler integration#31

Merged
RoryBarnes merged 1 commit intomainfrom
comprehensive-testing
Dec 30, 2025
Merged

Deprecate Hyak PBS/Torque scheduler integration#31
RoryBarnes merged 1 commit intomainfrom
comprehensive-testing

Conversation

@RoryBarnes
Copy link
Contributor

Remove obsolete PBS/Torque job submission functionality that was specific to UW's legacy Hyak cluster (migrated to Slurm in 2020).

Changes:

  • Delete vspace/hyak.py and vspace/vspace_hyak.py (399 lines removed)
  • Remove vspace_hyak import from vspace/vspace.py
  • Remove dead code block (if False:) containing hyak calls (34 lines)
  • Add TESTING.md documenting subprocess coverage methodology
  • Update CLAUDE.md Phase 5 to mark deprecation complete
  • Add deprecation notice to README.md

Rationale:

  1. Multiplanet provides superior parallel execution without scheduler deps
  2. PBS/Torque is legacy; modern HPC uses Slurm
  3. Code was already disabled (wrapped in "if False:")
  4. Hardcoded for single user (paths: /gscratch/stf/dflemin3/)

Users needing HPC integration should use multiplanet in interactive sessions or develop Slurm job array workflows.

🤖 Generated with Claude Code

Remove obsolete PBS/Torque job submission functionality that was specific
to UW's legacy Hyak cluster (migrated to Slurm in 2020).

Changes:
- Delete vspace/hyak.py and vspace/vspace_hyak.py (399 lines removed)
- Remove vspace_hyak import from vspace/vspace.py
- Remove dead code block (if False:) containing hyak calls (34 lines)
- Add TESTING.md documenting subprocess coverage methodology
- Update CLAUDE.md Phase 5 to mark deprecation complete
- Add deprecation notice to README.md

Rationale:
1. Multiplanet provides superior parallel execution without scheduler deps
2. PBS/Torque is legacy; modern HPC uses Slurm
3. Code was already disabled (wrapped in "if False:")
4. Hardcoded for single user (paths: /gscratch/stf/dflemin3/)

Users needing HPC integration should use multiplanet in interactive
sessions or develop Slurm job array workflows.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Test Results (py3.9 on ubuntu-22.04)

46 tests  ±0   46 ✅ ±0   1m 17s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f282957. ± Comparison against base commit 7a1f4c1.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.81%. Comparing base (73365fb) to head (f282957).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #31       +/-   ##
===========================================
+ Coverage   56.59%   71.81%   +15.21%     
===========================================
  Files           4        2        -2     
  Lines         629      486      -143     
===========================================
- Hits          356      349        -7     
+ Misses        273      137      -136     
Flag Coverage Δ
ubuntu-22.04-py3.9 71.81% <ø> (+15.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
vspace/vspace.py 71.51% <ø> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoryBarnes RoryBarnes merged commit e18815b into main Dec 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant