Skip to content

refactor(TeacherProjectService): Move getBranchLetter to OneWorkgroupPerRowDataExportStrategy#1558

Draft
hirokiterashima wants to merge 1 commit intodevelopfrom
refactor-teacherProjectService-getBranchLetter
Draft

refactor(TeacherProjectService): Move getBranchLetter to OneWorkgroupPerRowDataExportStrategy#1558
hirokiterashima wants to merge 1 commit intodevelopfrom
refactor-teacherProjectService-getBranchLetter

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Move TeacherProjectService.getBranchLetter() to OneWorkgroupPerRowDataExportStrategy.getBranchLetter(). OneWorkgroupPerRowDataExportStrategy was the only class that was calling this function.

Test

  • Export "One Workgroup per Row" for a run with a branch. Verify that the export has a "Branch Path Taken" column with the correct value

OneWorkgroupPerRowDataExportStrategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant