feat(IdeasSummary): Show student responses#2268
Conversation
❌ 4 blocking issues (4 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| { text: 'Computer response 2', ideas: [{ detected: true, name: 'idea2' }] } | ||
| ] | ||
| } | ||
| }) |
| { text: 'Computer response 1b', ideas: [{ detected: true, name: 'idea1' }] } | ||
| ] | ||
| } | ||
| }) |
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
hirokiterashima
added
the
enhancement
breity
left a comment
breity
left a comment
There was a problem hiding this comment.
Functionality is great. I updated to utilize MatExpansionPanel for expanding and collapsing and updated styles. I also added "Sample responses:" text above the responses display.
|
🎉 This PR is included in version 5.208.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Notes
Please style as you see fit. It would be great to distinguish between the responses a bit more, with maybe a border or background. Maybe make the responses italic?
Also, as you can see in the image below, the expanded idea has 3 students who had this idea, but we only show 2 users. Would this be a bit confusing because users might expect to see 3 students? Maybe we should explain this in the UI, like displaying a message "showing 2 of 3 responses" or "sample responses" in the expanded panel, or "click to see sample responses" when hovering over the expand icon?
Changes
Test