Skip to content

feat(GradeByStep): Sync class responses with summary#2269

Merged
hirokiterashima merged 2 commits intodevelopfrom
grade-by-step-visible-components-sync-with-summary
Feb 18, 2026
Merged

feat(GradeByStep): Sync class responses with summary#2269
hirokiterashima merged 2 commits intodevelopfrom
grade-by-step-visible-components-sync-with-summary

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Feb 9, 2026

Changes

This change makes the grade-by-step view less confusing, by only displaying one component when the page is first loaded. Before, we were showing all the components (and their combined score) in the step, but were showing one summary, so this mismatch was confusing.

Test

  • In the grade-by-step view, Class Responses section now shows the same component as in the summary tab.
  • When the step is first loaded, we show the first component in the step.
  • Choosing a different component in the summary updates the class responses section to show responses for that same component.

@hirokiterashima hirokiterashima self-assigned this Feb 9, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Feb 9, 2026
@qltysh
Copy link

qltysh bot commented Feb 9, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...s/nodeGrading/filter-components/filter-components.component.ts100.0%
New file Coverage rating: B
...rComponents/nodeGrading/node-grading/node-grading.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review February 9, 2026 20:12
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hirokiterashima hirokiterashima merged commit 3e6e78b into develop Feb 18, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the grade-by-step-visible-components-sync-with-summary branch February 18, 2026 05:11
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.207.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants