Fix: strip diacritics in step 3 CSV filter #2
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library stores ASCII names ("Bjork") but Discogs uses diacritics
("Björk"). The step 3 filter compared with .lower().strip() only, so
all releases for diacritics artists were silently excluded from the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
normalize_artist()only did.lower().strip(), so"björk" != "bjork"and all releases for those artists were silently excluded from the cacheunicodedata.normalize('NFKD')to strip diacritics before comparing, matching the approach already used in step 8'sverify_cache.pyTest plan
TestNormalizeArtistcases still passtest_filter_csv.pysuite passes (28 tests)