Fixing Double to Long conversion for chainId #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Double to Long conversion for chainId
Contributor
|
thanks - validated the fix works with #77 |
ligi
approved these changes
Jul 17, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
to validate PR #76
art-shen
pushed a commit
to art-shen/WalletConnectKotlinV1
that referenced
this pull request
Apr 6, 2023
to validate PR WalletConnect#76 Signed-off-by: Artyom Shendrik <artyom.shendrik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered chainId was always set to null, the reason this was happening was because of a wrong cast from Double to Long.
Another person also reported the issue here