-
Notifications
You must be signed in to change notification settings - Fork 1
[fix] 유저 웨이블존 저장 및 조회 관련 API 수정 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8503d61
3e37fa9
6bcd32b
a9b7c9a
aec33b8
c288b5b
2fbb794
9700c53
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.wayble.server.user.dto; | ||
|
|
||
| import jakarta.validation.constraints.NotEmpty; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import java.util.List; | ||
|
|
||
| public record UserPlaceAddZonesRequestDto( | ||
| @NotNull Long placeId, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 하나의 플래이스 리스트에 동시에 여러 개의 웨이블존을 추가하는 경우는 없을 것 같습니다! 따라서 placeId는 리스트로, waybleZoneId는 단일 Long 값으로 받는게 좋을 것 같다는 생각입니다!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ㅋㅋㅋㅋㅋ 반대로 했네요 ㅠ.ㅠ 수정했습니다 |
||
| @NotEmpty List<Long> waybleZoneIds | ||
| ) {} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.wayble.server.user.dto; | ||
|
|
||
| import jakarta.validation.constraints.NotBlank; | ||
|
|
||
| public record UserPlaceCreateRequestDto( | ||
| @NotBlank(message = "제목은 필수입니다.") String title, | ||
| String color | ||
| ) {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.wayble.server.user.dto; | ||
|
|
||
| import lombok.Builder; | ||
|
|
||
| @Builder | ||
| public record UserPlaceCreateResponseDto( | ||
| Long placeId, | ||
| String title, | ||
| String color, | ||
| String message | ||
| ) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 엔드포인트에 /zones가 붙어야 할 것 같아요!
현재 상태면 아예 장소 리스트를 삭제하는 걸로 오해할 것 같습니다!