New xdg_shell_stable surface log fix #2824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'loaded mode' message is emitted during output initialization when enumerating available display modes. Since backend/drm/drm.c already handles that info, repeating this information at INFO level in Wayfire results in redundant output.
Contributor
Author
|
I guess app-id is fine but title is not good for privacy in case the user wants to share the logs, I would recommend to remove title and have only app-id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure you will like the log in a set_callback but the result is this:
before that, was just [src/view/xdg-shell/xdg-toplevel-view.cpp:29] new xdg_shell_stable surface: (null) app-id: (null)