Added "Default Ranges" to Ritual Documentation. + Related Tweaks.#1930
Open
VT-14 wants to merge 1 commit intoWayofTime:1.18.2from
Open
Added "Default Ranges" to Ritual Documentation. + Related Tweaks.#1930VT-14 wants to merge 1 commit intoWayofTime:1.18.2from
VT-14 wants to merge 1 commit intoWayofTime:1.18.2from
Conversation
* Added new "Default Ranges" page type. Applied to all relevant Ritual entries. * Removed `RitualInfoProcessor`. Replaced with a new `RitualProcessorCore`, `RitualDataProcessor`, and `RitualInfoProcessor`. Added completley new `RitualRangesProcessor`. Core contains the shared code for all 3. * Removed the Blood Altar link from the "List of Rituals" category text. Due to a bug in Patchouli it would be clicked instead of the actual Ritual Entry someone wanted. * Added "waterTank" area description to the Water Ritual entry.
keraldi
approved these changes
Oct 14, 2022
Collaborator
keraldi
left a comment
keraldi
left a comment
There was a problem hiding this comment.
Project maintaining person: evaluate whether or not this cache folder can be nuked
| 3c6ce233dae6c1307d9016406c324bbe844b4e1e assets/bloodmagic/blockstates/wornstonebrickpath.json | ||
| d59655f12d1724b73b77c373fb6864fcff69db12 assets/bloodmagic/blockstates/wornstonetilepath.json | ||
| 739d3af2c9fba76f1465d032b80fc205c3b19df9 assets/bloodmagic/lang/en_us.json | ||
| 347bb4182165f1a5b19f5fdb2f208b9da73e02c1 assets/bloodmagic/lang/en_us.json |
Collaborator
There was a problem hiding this comment.
The cache folder in its entirety, honestly, not really this change.
VT-14
added a commit
to VT-14/BloodMagic
that referenced
this pull request
Jan 26, 2024
Squash-Merge the 1.18 PR branch into a new 1.20 branch. commit 0f2cfdd Author: VT-14 <GamingVT14@Gmail.com> Date: Sat Sep 3 23:55:06 2022 -0400 Added "Default Ranges" to Ritual Documentation * Added new "Default Ranges" page type. Applied to all relevant Ritual entries. * Removed `RitualInfoProcessor`. Replaced with a new `RitualProcessorCore`, `RitualDataProcessor`, and `RitualInfoProcessor`. Added completley new `RitualRangesProcessor`. Core contains the shared code for all 3. * Removed the Blood Altar link from the "List of Rituals" category text. Due to a bug in Patchouli it would be clicked instead of the actual Ritual Entry someone wanted. * Added "waterTank" area description to the Water Ritual entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
RitualInfoProcessor. Replaced with a newRitualProcessorCore,RitualDataProcessor, andRitualInfoProcessor, andRitualRangesProcessorin a sub-folder. Core contains the shared code for the other 3.Clarified that the "data" page ranges are maximum ranges.
Removed the Blood Altar link from the "List of Rituals" category text. Due to a bug in Patchouli it would be clicked instead of the actual Ritual Entry someone wanted.
Added missing "waterTank" area description to the Water Ritual entry.
Added missing label ("Fight Range") to "ritual.bloodmagic.condorRitual.flightRange.info".
Fixes #1928