Skip to content

remove dependency on storify for controllers/user.py#857

Open
sl1-1 wants to merge 2 commits intoWeasyl:mainfrom
sl1-1:remove-storify-from-controllers-user
Open

remove dependency on storify for controllers/user.py#857
sl1-1 wants to merge 2 commits intoWeasyl:mainfrom
sl1-1:remove-storify-from-controllers-user

Conversation

@sl1-1
Copy link
Copy Markdown
Contributor

@sl1-1 sl1-1 commented Aug 22, 2020

Related to #744

update tests to reflect changes to login.py and resetpassword.py
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 22, 2020

This pull request introduces 2 alerts when merging 823fb76 into f277273 - view on LGTM.com

new alerts:

  • 2 for Redundant assignment

Comment thread weasyl/login.py Outdated
Copy link
Copy Markdown
Member

@kfkitsune kfkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines +245 to +254
login.create(
request.params.get('username', ''),
request.params.get('email', ''),
request.params.get('emailcheck', ''),
request.params.get('password', ''),
request.params.get('passcheck', ''),
request.params.get('year', ''),
request.params.get('month', ''),
request.params.get('day', '')
)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could benefit from some named argument safety:

Suggested change
login.create(
request.params.get('username', ''),
request.params.get('email', ''),
request.params.get('emailcheck', ''),
request.params.get('password', ''),
request.params.get('passcheck', ''),
request.params.get('year', ''),
request.params.get('month', ''),
request.params.get('day', '')
)
login.create(
username=request.params.get('username', ''),
email=request.params.get('email', ''),
emailcheck=request.params.get('emailcheck', ''),
password=request.params.get('password', ''),
passcheck=request.params.get('passcheck', ''),
year=request.params.get('year', ''),
month=request.params.get('month', ''),
day=request.params.get('day', ''),
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants