[emscripten] Drop -sWASM=0 variant build
#7995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 24, 2025
| else() | ||
| target_link_libraries(binaryen_js PRIVATE "-sEXPORT_ES6=1") | ||
| # Currently, js_of_ocaml can only process ES5 code | ||
| target_link_libraries(binaryen_js PRIVATE "-sEXPORT_ES6") |
There was a problem hiding this comment.
Hmm, I don't recall the background here, but if js_of_ocaml has issues with ES6, maybe it also does with wasm?
sbc100
force-pushed
the
drop_pure_js
branch
2 times, most recently
from
4e05087 to
ccdd06a
Compare
There is now just one emscripten target called `binaryen_js`. The settings for these two targets were almost identical except for. 1. Some JS_OF_OCAML specific stuff which is kept for the new unified target. 2. `-sASSERTIONS` was being forced (See #2507). I dropped this in favor of doing a debug build in testing where this is enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now just one emscripten target called
binaryen_js. The settings for these two targets were almost identical except for.-sASSERTIONSwas being forced (See Avoid errors in binaryen.js assertions builds, and enable ASSERTIONS in debug builds. #2507). I dropped this in favor of doing a debug build in testing where this is enabled by default.