[wasm-split] End module names with : in manifests #8003
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by by @sbc100 (emscripten-core/emscripten#25577 (comment)). Currently this supports both module names with a `:` and without it for backwards compatibility and also to pass the CI.
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Oct 27, 2025
This makes better distinction of module names and function lists. Suggested by by @sbc100 (emscripten-core#25577 (comment)). This has to land after WebAssembly/binaryen#8003.
sbc100
reviewed
Oct 27, 2025
|
|
||
| IString substr(size_t pos, size_t len = std::string_view::npos) const { | ||
| return IString(str.substr(pos, len)); | ||
| } |
There was a problem hiding this comment.
Has binararyen really gone this long without a substr() or endswith() operations on strings?
| Name name = WasmBinaryReader::escape(line); | ||
| if (newSection) { | ||
| if (name.endsWith(":")) { | ||
| name = name.substr(0, name.size() - 1); |
There was a problem hiding this comment.
You could be clever and allow (0, -1) here like in high level languages?
There was a problem hiding this comment.
In basic_string_view::substr, the second argument is a count, the number of characters, so I think making the meaning of IString::substr different will be confusing. If we want that behavior we can add a separate function like slice(size_t start, size_end) or something. But we only have a single use here now, so I'm not sure if that's necessary at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes better distinction of module names and function lists. Suggested by by @sbc100 (emscripten-core/emscripten#25577 (comment)).
Currently this supports both module names with a
:and without it for backwards compatibility and also to pass the CI.