Skip to content

Conversation

@GKraats
Copy link

@GKraats GKraats commented Jun 12, 2024

Since a short time aquarium totally fails if webgl2 not available.
I am running an old Dell laptop with linux Debian Testing
and firefox, which does not support webgl2.
It only shows a page with misleading errormessage:
"It does not appear your computer supports WebGL"
and loops with varying fps-count.

Problem is caused by recent merge #42.

At aquarium/aquarium-config.js it sets enableVR: true,
causing webgl2 to become the preferred driver.
The first check for driver webgl2 fails, causing the
display of the error-page.
The next check for driver webgl succeeds, causing the
program to continue, but probably because of the active error-page,
it fails displaying the aquarium.

Problem can be solved at tdl/webgl.js at
tdl.webgl.setupWebGL.
Function handleCreationError should only
generate the message but not show it.
The message should be only shown at the end of
tdl.webgl.setupWebGL, if no context is available.

Aquarium is a standard and nice webgl-example, so it should support webgl.
~      

@GKraats GKraats mentioned this pull request Jun 12, 2024
@kainino0x kainino0x requested a review from toji June 12, 2024 20:51
@brianpeiris
Copy link
Contributor

For what it's worth, I did some cursory testing in various browsers and this doesn't seem to break anything.

@GKraats
Copy link
Author

GKraats commented Dec 2, 2024

It would be nice if this pull-request finally becomes merged.

Aquarium is the first application at https://webglsamples.org/ and it is a very nice one.

It now shows the misleading message : "It does not appear your computer supports WebGL", even if WebGL is available and only WebGL2 not.

At Google "aquarium WebGL not supported" problems still are reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants