Skip to content

Conversation

@nmuthu973
Copy link

@nmuthu973 nmuthu973 commented Nov 5, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing header includes and removes an unnecessary allocator definition to fix compilation when ENABLE(MALLOC_HEAP_BREAKDOWN) is enabled.

  • Added <wtf/NeverDestroyed.h> includes to files using DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER macro
  • Added LoaderMalloc.h include to CachedSVGDocumentReference.h for heap identifier usage
  • Removed redundant DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER from FrameRateAligner.cpp

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Source/WebCore/rendering/style/StyleSurroundData.cpp Adds NeverDestroyed.h include required by DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER macro
Source/WebCore/platform/graphics/Region.cpp Adds NeverDestroyed.h include required by DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER macro
Source/WebCore/loader/cache/CachedSVGDocumentReference.h Adds LoaderMalloc.h include for WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER usage
Source/WebCore/animation/FrameRateAligner.cpp Removes unnecessary DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER since it's not needed (class uses heap identifier through header)
Source/WTF/wtf/text/StringImpl.cpp Adds NeverDestroyed.h include required by DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER macro

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@modeveci modeveci requested a review from magomez November 6, 2025 08:59
@magomez magomez merged commit 692a0e6 into WebPlatformForEmbedded:wpe-2.46 Nov 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants