This repository was archived by the owner on Mar 3, 2022. It is now read-only.
Refactoring and new generator to aid in responses. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure removing 37,958 lines of code - albeit some of them just comments - is the right way to handle things. You might consider staging this commit, because you do have some good changes. However, not all of them are good. |
|
This is a huge diff to come in one commit. Try breaking it up into smaller commits, it would make it much easier to review and cherry pick changes. |
|
This is not a commit made with any honest intent to improve the existing work. Political irony noted, but let's close this pull request and get on with working to improve the codebase for use by other groups and organizations. |
bryanhirsch
pushed a commit
to bryanhirsch/petitions
that referenced
this pull request
Apr 30, 2013
PT-563: Update style.css to show the home icon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the code base much cleaner while allowing future responses to be issued in an automated manner. We just need to add a few more generic adjectives and adverbs and this new functionality will truly shine!