fix infinite fetching of users triggering loop #94
Conversation
NollieChtn6
requested review from
CarolineGensac,
bechir-elya,
Copilot and
raphaelmrn
There was a problem hiding this comment.
Pull Request Overview
This PR refactors user management by renaming the User interface to UserMapped and consolidating data fetching to use Zustand store. The changes eliminate duplicate GraphQL queries in the UserManager component by leveraging the centralized fetchUsers method from the user store, and fixes a critical bug where isLoading was incorrectly set to false when fetching users should set it to true.
- Renamed
Userinterface toUserMappedto better reflect its purpose - Removed redundant
useGetUsersQueryhook from UserManager in favor of Zustand store'sfetchUsersandusersstate - Fixed critical bug:
isLoadingnow correctly set totruewhen fetching users begins - Improved code consistency with formatting and accessibility enhancements
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/store/userStore.ts | Renamed User interface to UserMapped and fixed isLoading bug in fetchUsers |
| frontend/src/pages/ModificationProfile/ModificationProfile.tsx | Updated import and type cast to use UserMapped |
| frontend/src/pages/Login/Login.tsx | Simplified store selector by using object destructuring |
| frontend/src/pages/Admin/components/UserList.tsx | Updated to use UserMapped type and applied code formatting |
| frontend/src/pages/Admin/components/UserEditForm.tsx | Added accessibility attributes and type="button" to buttons, improved formatting |
| frontend/src/pages/Admin/components/UserCard.tsx | Updated to use UserMapped type and applied code formatting |
| frontend/src/pages/Admin/UserManager.tsx | Removed useGetUsersQuery hook and refetch calls in favor of Zustand store state and methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (isLoading) return <p>Chargement des utilisateurs...</p>; | ||
| if (!users.length) return <p>Aucun utilisateur trouvé.</p>; |
There was a problem hiding this comment.
The loading state check occurs before initial data fetch. If users is an empty array on first render and isLoading is false (initial state), it will immediately show 'Aucun utilisateur trouvé' even though users haven't been fetched yet. This creates a confusing UX where users see 'no users found' before any fetch attempt. This issue is related to the missing fetchUsers() call on mount.
No description provided.