Skip to content

Trusts: Added listnames setting. #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vessellaj wants to merge 1,329 commits into
base: dev
Choose a base branch
from
Open

Trusts: Added listnames setting. #2204

vessellaj wants to merge 1,329 commits into from

Conversation

@vessellaj
Copy link
Contributor

@vessellaj vessellaj commented Jul 6, 2022

No description provided.

z16 and others added 30 commits September 16, 2021 04:52
@z16
Merge pull request Windower#2078 from KenshiDRK/Slips-Update
254835f 
Update slips.lua
@funkworkz
Update setbgm.lua
3f65070 
Two new songs added in the September 2021 update. Names are not known yet.
@Byrth
Fix gearswap (requires monster_skills.lua)
209a739
@Byrth
fix shortcuts (requires monster_skills.lua)
60e6d5a
@Byrth
version bumps
82e6653
@Chiaia
Merge pull request Windower#2079 from funkworkz/patch-2
5a233e8 
Update setbgm.lua
@z16
Merge pull request Windower#2080 from Windower/gearswap-shortcuts-mon…
00cbce7 
…strosity-fix

Gearswap shortcuts monstrosity fix
@trv6
A few functions for decoding dialog entries
02f95fa 
Locals, spacing


dev table, format arg, no more length


the rest of the owl
@Chiaia
Update messages and Add Low/Mid D Tower to be extracted
f04b053
@Chiaia
Merge pull request Windower#2083 from Windower/dev
02a3325 
Dev -> Live
@z16
Merge pull request Windower#2081 from trv6/dialog
b2ab69c 
A few functions for decoding dialog entries
@Byrth
change based on CHA CHA CHA's info
84cc1a7
@Byrth
Merge pull request Windower#2084 from Windower/adjust_0x01C_incoming
e4432cf 
change based on CHA CHA CHA's info
@Byrth
fixed comment numbering for 0x01C
566a726
@Byrth
Merge pull request Windower#2085 from Windower/fix_comment_numbering
ea338e4 
fixed comment numbering for 0x01C
@Chiaia
Merge pull request Windower#2087 from Windower/dev
27d87e9 
Dev -> Live
@zetaepyon
Update README.md
394ebfb
@xurion
Update Mount Roulette to 3.1.0.
b09d2e3 
Add blacklist function.
@RubenatorX
Master Levels Update 1
f774195
@alphaONE2
Merge pull request Windower#2091 from RubenatorX/patch-12
60e1e9b 
Master Levels Update 1
@KenshiDRK
[thtracker] variable fix
0023a17 
variable fix
@KenshiDRK
Slips lib Update
411d14f 
Adding Chemistry Set and Goujian to Slips library
@Nifim
Merge pull request Windower#2093 from KenshiDRK/Slips
21b32bd 
Slips lib Update
@Chiaia
Merge pull request Windower#2092 from KenshiDRK/Thtracker
657bd2d 
[thtracker] variable fix
@Chiaia
Fix dupe label
6e2dbc3
@Chiaia
Merge pull request Windower#2094 from Windower/dev
13001f9 
Dev -> Live
@RubenatorX
Update Master Level 2
5ade870 
Changed to use boolbits and added Master Levels menu display data
@RubenatorX
Master Levels Update 2
22b865b 
Change to use Refs
@RubenatorX
Master Level Update 2
ffa2cce 
Re-add Master flags comment
@RubenatorX
Master Level Update 2
cf18fa9 
spacing fix
StarlitGhost and others added 25 commits May 24, 2022 18:38
@StarlitGhost
[gametime] bump version, add copyright date 2022
10e0956
@Nifim
Merge pull request Windower#2192 from StarlitGhost/patch-1
2c76be6 
[gametime] fix //gt route
@vessellaj
Fix for player party member out-of-zone
a54a5c5
@z16
Merge pull request Windower#2193 from vessellaj/patch-1
c00b155 
Trusts: Fix for player party member out-of-zone
@RubenatorX
DST time offset fix
2de084d
@z16
Fields: Refactored buff time calculation
7e39d8e
@z16
Fields: Incremented year count for buff time calculation
a36eadd
@Byrth
Add items for June 2022 Update
15de262
@Byrth
Merge pull request Windower#2195 from Windower/update-slips-2022-06
3c094c0 
Add items for June 2022 Update
@Algelius
Update Yush.lua
fe39145 
Added DIKs for f13-f15.
@Algelius
Update Yush.lua
6bc9be2
@Algelius
Update Yush.lua
2762180 
DIKs for f11 & f12
@z16
Merge pull request Windower#2196 from Algelius/dev
8434022 
Yush.lua updated DIKs
Added VerboseKeys setting.
efe0f62
Wording update.
b240a1e
Removed table identifier.
7bce71c
parse_binds no longer reassigns key.
fa2139c
output_text_table renamed, made list, and output text updated.
4d657ab
@z16
Merge pull request Windower#2197 from vessellaj/dev
2aeb06c 
Yush: Added a VerboseKeys setting to enable key display in each macro set.
@RubenatorX
[tables] add table.pack
18413aa
@RubenatorX
[Gearswap][Motes-Mappings] Ltng. Threnody
0491d6d 
There is no spell called "Lightning Threnody"
@KenshiDRK
[fields lib] fix wrong 0x0E8 packet direction
c3d811d 
0x0E8 is an outgoing packet.
@Byrth
Merge pull request Windower#2201 from KenshiDRK/field-lib
dfb29f0 
[fields lib] fix wrong 0x0E8 packet direction
@z16
Packets/Fields: Updated outgoing 0x061 length
6e4caf6
Added listnames setting.
7cd65fc
@RubenatorX
Copy link
Collaborator

RubenatorX commented Jul 6, 2022 •
edited
Loading

Wait so... if I'm following this code properly,
You have added a setting (with no command to modify it) that makes it so that the list command spits out all trusts that are in all the sets?

It would be better if instead of that, the list command had an optional subcommand that would list out the trusts from a named set -- e.g.: trusts list vw

And then if for some reason you really really wanted to list out basically the entire contents of the settings file (for that character), could add a special flag -- maybe -verbose or something (maybe @z16 has thoughts).

But I don't think adding a hidden(read: have to go directly edit the settings file) setting is the way to go for this.

@vessellaj
Copy link
Contributor Author

vessellaj commented Jul 7, 2022

Fair enough. I've added a toggle to the main commands for the name printing and a subcommand option for trusts list as asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.