AbstractClassRestrictionsSniff sniffs: add tests for namespaced names #2643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the 'namespace' keyword) as well as fully qualified global function calls to the sniffs that extend the
AbstractClassRestrictionsSniffclass when necessary. Some test files already contained part or all of the required tests.For
DeprecatedClasses, I opted to add the tests in a separate file as the error linesDeprecatedClassesUnitTest.1.incare generated dynamically. Since the tests were added to a separate file, I opted to include all possible namespace variations even though a few already exist inDeprecatedClassesUnitTest.1.inc. I didn't want to complicate things by having the namespaced names tests in different files.Suggested changelog entry
N/A