Skip to content

Conversation

@jorgefilipecosta
Copy link
Member

This PR applies feedback provided in #108, by @aaronjorbin as a preparation for the core patch.

Testing

Verify automated testing pass.
Oppenened the editor, and the browser console, made some test requests:

wp.apiFetch({ path: wp.url.addQueryArgs('/wp/v2/abilities/core/get-site-info/run', { fields:[ 'name' ] } ) } ).then(console.log);
wp.apiFetch({ path: wp.url.addQueryArgs('/wp/v2/abilities/core/get-site-info/run', {input: { fields:[ 'name' ] } } ) } ).then(console.log);

Verified things return as expected.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 98.23009% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (9da857e) to head (e1179cb).

Files with missing lines Patch % Lines
includes/bootstrap.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #127      +/-   ##
============================================
+ Coverage     90.59%   90.69%   +0.09%     
+ Complexity      177      166      -11     
============================================
  Files            20       20              
  Lines          1489     1408      -81     
  Branches        117      116       -1     
============================================
- Hits           1349     1277      -72     
+ Misses          140      131       -9     
Flag Coverage Δ
javascript 94.20% <ø> (ø)
unit 89.62% <98.23%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27
Copy link
Member

Some PHPCS issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants