Skip to content

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Jan 7, 2026

According to the Polyglots team, this remains the recommended method for loading the textdomain when translations from WordPress.org are unavailable for some reason. Therefore, it is not yet time to block this function call entirely. This PR changes its handling from an error to a warning and severity also has been updated.

@ernilambar ernilambar force-pushed the convert-load-plugin-textdomain-check-to-warning branch 2 times, most recently from a9a0185 to f01b9c4 Compare January 7, 2026 04:16
@ernilambar ernilambar marked this pull request as ready for review January 7, 2026 04:24
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <nilambar@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar force-pushed the convert-load-plugin-textdomain-check-to-warning branch from f01b9c4 to ec0fb5e Compare January 7, 2026 04:45
@ernilambar ernilambar force-pushed the convert-load-plugin-textdomain-check-to-warning branch from ec0fb5e to 17e1e5b Compare January 7, 2026 04:48
@ernilambar ernilambar added this to the 1.9.0 milestone Jan 8, 2026
@ernilambar ernilambar merged commit 97b16f3 into trunk Jan 8, 2026
27 checks passed
@ernilambar ernilambar deleted the convert-load-plugin-textdomain-check-to-warning branch January 8, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants