Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Jan 2, 2026

What

Follow-up to #333. Adds additional PHPUnit tests for form type classes.

How

File Tests Added
test-form-comment test_edit_comment_renders_nothing_without_field_groups
test-form-front test_enqueue_form_calls_check_submit_form, test_submit_form_applies_pre_submit_filter, test_submit_form_fires_action, test_submit_form_sets_global
test-form-gutenberg test_add_meta_boxes_removes_edit_form_after_title_action, test_block_editor_meta_box_hidden_fields_method_exists
test-form-nav-menu test_admin_enqueue_scripts_bails_when_not_on_nav_menus_screen
test-form-taxonomy test_admin_enqueue_scripts_bails_on_wrong_page
test-form-user test_admin_enqueue_scripts_bails_when_not_on_user_screen, test_render_edit_renders_nothing_without_field_groups, test_render_edit_with_different_user_ids
test-form-widget test_admin_enqueue_scripts_bails_when_not_on_widgets_screen

Testing Instructions

Run the form type tests:

vendor/bin/phpunit --filter="Test_Form"

@priethor priethor added this to the 6.9.0 milestone Jan 2, 2026
@priethor priethor self-assigned this Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.89%. Comparing base (af9ae43) to head (af4b1f4).
⚠️ Report is 4 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #347      +/-   ##
============================================
+ Coverage     31.71%   31.89%   +0.17%     
  Complexity     4410     4410              
============================================
  Files           291      291              
  Lines         36918    36914       -4     
============================================
+ Hits          11710    11775      +65     
+ Misses        25208    25139      -69     
Flag Coverage Δ
e2e 42.91% <ø> (-0.51%) ⬇️
javascript 15.07% <ø> (ø)
phpunit 29.08% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priethor priethor force-pushed the 43ef-phase-2-pr-11-fo branch from 40c5eee to af4b1f4 Compare January 2, 2026 23:57
@priethor priethor merged commit 1e1f998 into trunk Jan 3, 2026
9 checks passed
@priethor priethor deleted the 43ef-phase-2-pr-11-fo branch January 3, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants