Skip to content

Conversation

@justlevine
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/52217

This PR fixes an issue in WP_Navigation_Block_Renderer where ::get_inner_blocks_from_navigation_post() and block_core_navigation_get_classic_menu_fallback() could potentially return void instead of their documented return types.

The issue is remediated by explicitly returning null (how void gets naturally coerced when assigning to a variable), as the most minimal change to address the issue while still persevering backcompat.

While this issue was surfaced via PHPStan in #7619 (trac: https://core.trac.wordpress.org/ticket/61175 ), it can be remediated independently of that ticket.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@justlevine justlevine changed the title fix: explicitly return null instead of coercing voids in WP_Navigation_Block_Renderer Fix: Explicitly return null instead of coercing voids in WP_Navigation_Block_Renderer Oct 29, 2024
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props justlevine.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@justlevine
Copy link
Author

wp-includes/blocks is not controlled by this repo

@justlevine justlevine closed this Oct 30, 2024
@justlevine justlevine deleted the fix/explicit-null-return-WP_Navigation_Block_Render branch October 30, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant