-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Limit the number of jobs that spawn for forks #9324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
johnbillion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can always trim down further at a later date if necessary.
aaronjorbin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment that I don't think needs there and a few notes, otherwise LGTM
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: [ '7.2', '8.4' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this should be 7.4instead of 7.2 if #9181 lands first
| php: [ '7.2', '8.4' ] | ||
| db-type: [ 'mysql' ] | ||
| db-version: [ '8.4' ] | ||
| # WordPress 4.9 is the oldest version that supports PHP 7.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # WordPress 4.9 is the oldest version that supports PHP 7.2. |
This looks like just copy paste rather than necessary based on the matrix
| fail-fast: false | ||
| matrix: | ||
| os: [ 'ubuntu-24.04' ] | ||
| php: [ '7.2', '8.4' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this should be 7.4instead of 7.2 if #9181 lands first
|
I've made adjustments to the conditions to support running the full test suite for private forks that may or may not exist within the organization while still limiting forks outside of the org. |
This limits the number of jobs that can run when a pull request is opened within a fork to a maximum of:
These jobs are spread out across 10 different workflows, and the maximum only occurs when the required run criteria for all 9 workflows is met. When only PHP files are modified, there are 28 jobs across 7 workflows with 14 taking less than 2 minutes and just 12 taking longer.
A single pull request should now take no longer than 15 minutes for the full array of jobs to complete.
Trac ticket: Core-63752.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.