Skip to content

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Jul 25, 2025

This limits the number of jobs that can run when a pull request is opened within a fork to a maximum of:

  • 29 jobs that run in a minute or less.
  • 6 jobs that take between 1 and 3 minutes.
  • 18 jobs that take longer.

These jobs are spread out across 10 different workflows, and the maximum only occurs when the required run criteria for all 9 workflows is met. When only PHP files are modified, there are 28 jobs across 7 workflows with 14 taking less than 2 minutes and just 12 taking longer.

A single pull request should now take no longer than 15 minutes for the full array of jobs to complete.

Trac ticket: Core-63752.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Jul 25, 2025
@github-actions
Copy link

github-actions bot commented Jul 25, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, johnbillion, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@johnbillion johnbillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can always trim down further at a later date if necessary.

Copy link
Member

@aaronjorbin aaronjorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that I don't think needs there and a few notes, otherwise LGTM

strategy:
fail-fast: false
matrix:
php: [ '7.2', '8.4' ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this should be 7.4instead of 7.2 if #9181 lands first

php: [ '7.2', '8.4' ]
db-type: [ 'mysql' ]
db-version: [ '8.4' ]
# WordPress 4.9 is the oldest version that supports PHP 7.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# WordPress 4.9 is the oldest version that supports PHP 7.2.

This looks like just copy paste rather than necessary based on the matrix

fail-fast: false
matrix:
os: [ 'ubuntu-24.04' ]
php: [ '7.2', '8.4' ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this should be 7.4instead of 7.2 if #9181 lands first

@desrosj
Copy link
Member Author

desrosj commented Aug 1, 2025

I've made adjustments to the conditions to support running the full test suite for private forks that may or may not exist within the organization while still limiting forks outside of the org.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60534
GitHub commit: d836928

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Aug 1, 2025
@desrosj desrosj deleted the limit-jobs-for-fork-prs branch August 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants