-
Notifications
You must be signed in to change notification settings - Fork 7
FED-3903 React 18 Upgrade Codemod #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
See preview in sourcegraph batch for more testing of this codemod: https://github.com/Workiva/sourcegraph-batch-changes/pull/840#issuecomment-3050531635 |
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments; this looks great!
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
rmconsole-wf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
This codemod updates react JS paths in html and dart files from the React 17 versions to the React 18 versions following the method of 1:1 updating the react.js paths and then removing the react_dom paths entirely since React 18 has it all in one file.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: