Skip to content

Conversation

@sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Jul 7, 2025

Motivation

This codemod updates react JS paths in html and dart files from the React 17 versions to the React 18 versions following the method of 1:1 updating the react.js paths and then removing the react_dom paths entirely since React 18 has it all in one file.

Changes

  • Add react_18_upgrade codemod
    • Updated existing suggestors and tests to do everything we need

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review July 8, 2025 21:25
@sydneyjodon-wk
Copy link
Contributor Author

See preview in sourcegraph batch for more testing of this codemod: https://github.com/Workiva/sourcegraph-batch-changes/pull/840#issuecomment-3050531635

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments; this looks great!

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-5 btr-rmconsole-5 bot merged commit 78aa2c8 into master Jul 14, 2025
3 checks passed
@btr-rmconsole-5 btr-rmconsole-5 bot deleted the react-18-updater branch July 14, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants