Skip to content

FED-4061 Use gha-dart-oss #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
btr-rmconsole-1 merged 6 commits into from
Aug 15, 2025
Merged

FED-4061 Use gha-dart-oss #322

btr-rmconsole-1 merged 6 commits into from
Aug 15, 2025

Conversation

@sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Aug 7, 2025 •
edited
Loading

We should set up gha-dart-oss so we can:

  • take advantage of shared workflows
  • use the publish workflow to auto-publish on merge 🎉

QA instructions

  • CI passes
  • All steps previously run in CI are still running even if some of them are in the shared jobs now
  • When this merges, follow along to make sure the package actually publishes

@sydneyjodon-wk sydneyjodon-wk mentioned this pull request Aug 8, 2025
Merged
2 tasks
@sydneyjodon-wk
Copy link
Contributor Author

sydneyjodon-wk commented Aug 8, 2025

The failing additional-checks will be fixed once Workiva/gha-dart-oss#42 merges

sydneyjodon-wk
sydneyjodon-wk commented Aug 8, 2025
View reviewed changes
.github/workflows/ci.yml
build:
uses: Workiva/gha-dart-oss/.github/workflows/build.yaml@v0.1.11

test:
Copy link
Contributor Author

@sydneyjodon-wk sydneyjodon-wk Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this was renamed, I'll update Rosie before this merges to look for the renamed check

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Unfortunately had to add each-sub job

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review August 8, 2025 23:09
@btr-rmconsole-3 btr-rmconsole-3 bot changed the title Use gha-dart-oss FED-4061 Use gha-dart-oss Aug 11, 2025
greglittlefield-wf
greglittlefield-wf approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@greglittlefield-wf
Copy link
Contributor

greglittlefield-wf commented Aug 15, 2025

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Aug 15, 2025
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-1 btr-rmconsole-1 bot merged commit 2be3ff8 into master Aug 15, 2025
9 checks passed
@btr-rmconsole-1 btr-rmconsole-1 bot deleted the use-gha-dart-oss branch August 15, 2025 16:03
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@matthewnitschke-wk matthewnitschke-wk Awaiting requested review from matthewnitschke-wk

Assignees

No one assigned

Labels

Merge Requirements Met RM Ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sydneyjodon-wk @greglittlefield-wf @rmconsole-wf