FEDX-4283: Remove options not compatible with current Dart 3 #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bender-wk
changed the title
|
Should we also modify https://github.com/Workiva/workiva_analysis_options/blob/master/lib/v2.recommended.yaml ? |
Contributor
Author
Recommended includes the regular one and does not list any of the problem rules itself. |
dustinlessard-wf
approved these changes
Nov 24, 2025
Contributor
Author
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDX-4283
Remove analysis options incompatible with Dart 3, and upgrade the pubspec to require Dart 3.
With this, packages running on Dart 2 will still see the older version, but it changes very rarely, so there shouldn't be a problem.
Reason:
Various options are removed in different Dart 3 versions. Trying to run intl_tools against latest I found the following errors.
There is a mechanism for downgrading the severity using removed_lints, but it's not introduced until Dart 3. 😭 So I guess we just remove these. Or make a v3 that people should use if switching to Dart 3, but that's going to be more painful.
warning - analysis_options.yaml:177:7 - 'iterable_contains_unrelated_type' was removed in Dart '3.3.0' Remove the reference to 'iterable_contains_unrelated_type'. - removed_lint
warning - analysis_options.yaml:180:7 - 'list_remove_unrelated_type' was removed in Dart '3.3.0' Remove the reference to 'list_remove_unrelated_type'. - removed_lint
warning - analysis_options.yaml:187:7 - 'prefer_equal_for_default_values' was removed in Dart '3.0.0' Remove the reference to 'prefer_equal_for_default_values'. - removed_lint
warning - analysis_options.yaml:202:7 - 'unsafe_html' was removed in Dart '3.7.0' Remove the reference to 'unsafe_html'. - removed_lint
warning - analysis_options.yaml:1:10 - Warning in the included options file /home/runner/.pub-cache/hosted/pub.dev/workiva_analysis_options-1.4.3/lib/v2.yaml(3689..3716): 'invalid_required_named_param' isn't a recognized error code. - included_file_warning
warning - analysis_options.yaml:1:10 - Warning in the included options file /home/runner/.pub-cache/hosted/pub.dev/workiva_analysis_options-1.4.3/lib/v2.yaml(3731..3763): 'invalid_required_positional_param' isn't a recognized error code. - included_file_warning